Modify doc NewCloudEventFromHTTPRequest -> NewEventFromHTTPRequest #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnotorni
force-pushed
the
hotfix/issue835_NewEventFromHTTPRequest
branch
2 times, most recently
from
853cc8f
to
e121124
Compare
Signed-off-by: rnotorni <kojiro.honkawa@geniee.co.jp>
rnotorni
force-pushed
the
hotfix/issue835_NewEventFromHTTPRequest
branch
from
e121124
to
de1dfea
Compare
rnotorni
changed the title
|
I can't figure out how to get github to rerun the tests - sigh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#835
This pull request has a difference between the document and the implementation.
The document defines it as NewCloudEventFromHTTPRequest, but it is actually NewEventFromHTTPRequet.