Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claim.Messages() seems returning nil sometime, avoid nil pointer #865

Merged
merged 2 commits into from Mar 15, 2023

Conversation

nbajaj90
Copy link
Contributor

claim.Messages() seems returning nil sometime, avoid nil pointer

Copy link

@rahulchheda rahulchheda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duglin
Copy link
Contributor

duglin commented Mar 15, 2023

Can you please sign your commit and check on the test failures?

@duglin
Copy link
Contributor

duglin commented Mar 15, 2023

Actually, it looks like the error may not be PR specific. So just signing your commits should be enough

/LGTM

@lionelvillard ?

@nbajaj90 nbajaj90 force-pushed the patch-1 branch 2 times, most recently from ee2b221 to ca17907 Compare March 15, 2023 19:12
claim.Messages() seems returning nil sometime, avoid nil pointer

Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
@nbajaj90
Copy link
Contributor Author

@lionelvillard PTAL

@lionelvillard lionelvillard merged commit 581f868 into cloudevents:main Mar 15, 2023
9 checks passed
@nbajaj90 nbajaj90 deleted the patch-1 branch March 15, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants