http: Fixes for Gin http receiver sample #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't forget to sign your commit(s) |
|
ping @embano1 |
dgeorgievski
force-pushed
the
http-samples-receiver-gin-fixes
branch
from
3504c71
to
f251383
Compare
Signed off. Sorry, I forgot. |
|
thanks. |
embano1
reviewed
Jun 3, 2023
| ```shell | ||
| curl -v \ | ||
| -H "Ce-Id: e7d95c20-6eb4-4614-946d-27b0ce41c7ff" \ | ||
| -H "Ce-Source: /apis///namespaces/dimitar//clone-build-n4qhgl" \ | ||
| -H "Ce-Source: /apis/namespaces/dimitar/clone-build-n4qhgl" \ |
There was a problem hiding this comment.
You need to change this in the output below too
There was a problem hiding this comment.
Source changed in the output as well.
Fixes for prematurely closed cloudevents#842 PR. Applied all suggested code and doc changes.. Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
dgeorgievski
force-pushed
the
http-samples-receiver-gin-fixes
branch
from
f251383
to
74c27a4
Compare
|
LGTM @embano1 and @lionelvillard FTM (for the merge) |
embano1
approved these changes
Jun 5, 2023
|
ping @lionelvillard for final approval/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for prematurely closed #842 PR. Applied all suggested code and doc changes.
It is worth mentioning the code and instructions come from a real use case of processing Tekton events:
https://tekton.dev/docs/pipelines/events/