Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT protocol binding #909

Closed
wants to merge 6 commits into from
Closed

Conversation

yanmxa
Copy link
Contributor

@yanmxa yanmxa commented Jul 4, 2023

Initial implementation of MQTT binding, using https://github.com/eclipse/paho.golang which supports MQTT V5

Note: This is just a basic implementation; some new features which are brought by MQTT 5.0 and other enhancements will be done in future PRs.

resolved: #901

Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
@yanmxa
Copy link
Contributor Author

yanmxa commented Jul 4, 2023

@duglin This PR is blocked by the Integration Tests. Which shows there are some issues from github.com/cloudevents/sdk-go/test/integration/nats. Since I didn't modify nats related files, I wonder if other PRs often have had similar issues?

@yanmxa yanmxa closed this Jul 5, 2023
@yanmxa
Copy link
Contributor Author

yanmxa commented Jul 5, 2023

I'm not sure why the latest commit from my branch isn't synced to this PR. So I closed this and open another PR(#910) for it.

@duglin
Copy link
Contributor

duglin commented Jul 5, 2023

@duglin This PR is blocked by the Integration Tests. Which shows there are some issues from github.com/cloudevents/sdk-go/test/integration/nats. Since I didn't modify nats related files, I wonder if other PRs often have had similar issues?

There are random race-condition failures in the tests, perhaps you were running into those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whether to consider adding MQTT protocol binding
2 participants