Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CESQL] Reorganize package implementation classes #397

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

slinkydeveloper
Copy link
Member

@slinkydeveloper slinkydeveloper commented Jun 7, 2021

Reorganized the impl subpackage in:

  • impl contains only the internal interfaces
  • impl.parser for the parsing and optimization related code
  • impl.runtime for the runtime related code
  • impl.functions for the built-in function implementations
  • impl.expressions for the expression implementations

No code was changed, except imports and changing visibility of some methods/classes.

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

@slinkydeveloper slinkydeveloper added this to the 2.2 milestone Jun 7, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impl 🤕

@pierDipi
Copy link
Member

LGTM, once CI is green.

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Jun 15, 2021
@slinkydeveloper slinkydeveloper merged commit baa9b59 into cloudevents:master Jun 15, 2021
@slinkydeveloper slinkydeveloper deleted the reorder-sql branch June 15, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants