Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: provide a Bill of Materials artifact for easier integration in… #405

Merged

Conversation

nvervelle
Copy link
Contributor

Easier integration of cloudevents into projects (see issue 404). It allows to :

  • Have cloudevents-bom with its version in dependencyManagement section (for Maven) or enforcedPlatform (for Gradle)
  • Have individual cloudevents modules without their version in each module that depends on cloudevents

@slinkydeveloper
Copy link
Member

Thanks for this PR, this is a nice contribution!

I wonder, can you add something to the repo root README and to the docs https://github.com/cloudevents/sdk-java/blob/master/docs/index.md about that?

@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Jun 25, 2021
@slinkydeveloper slinkydeveloper added this to the 2.3 milestone Jun 25, 2021
@slinkydeveloper slinkydeveloper linked an issue Jun 25, 2021 that may be closed by this pull request
@nvervelle
Copy link
Contributor Author

I wonder, can you add something to the repo root README and to the docs https://github.com/cloudevents/sdk-java/blob/master/docs/index.md about that?

Sure, I will add something in the docs :-)

… projects

Signed-off-by: Nicolas Vervelle <nicolas.vervelle@quicksign.com>
@nvervelle nvervelle force-pushed the 404-provide-bill-of-materials branch from 459c771 to aceab6e Compare June 25, 2021 15:21
@nvervelle
Copy link
Contributor Author

nvervelle commented Jun 25, 2021

@slinkydeveloper

I've added documentation in index.md about the new module, but I'm wondering if I should add something in the root README. The README links to index.md where the new module will be described: do you think something else is needed?

@slinkydeveloper
Copy link
Member

do you think something else is needed?

I think it's good now, the pom could be useful for a getting started page, that we don't have atm :)

@slinkydeveloper slinkydeveloper merged commit 73a3c37 into cloudevents:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a Bill of Materials for easier integration in projects
2 participants