Ignore not valid extension name in jackson CloudEventDeserializer #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mhyeon-lee <mhyeon.lee@navercorp.com>
mhyeon-lee
force-pushed
the
ignore-not-valid-extension-name-in-cloud-event-deserializer
branch
from
a2344e1
to
20f367d
Compare
pierDipi
requested changes
Dec 7, 2021
formats/json-jackson/src/main/java/io/cloudevents/jackson/CloudEventDeserializer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mhyeon-lee <mhyeon.lee@navercorp.com>
mhyeon-lee
force-pushed
the
ignore-not-valid-extension-name-in-cloud-event-deserializer
branch
from
cc4963e
to
2c71c8a
Compare
pierDipi
reviewed
Dec 9, 2021
formats/json-jackson/src/main/java/io/cloudevents/jackson/JsonFormat.java
Outdated
Show resolved
Hide resolved
mhyeon-lee
force-pushed
the
ignore-not-valid-extension-name-in-cloud-event-deserializer
branch
2 times, most recently
from
bd32f3e
to
e23463a
Compare
Signed-off-by: mhyeon-lee <mhyeon.lee@navercorp.com>
mhyeon-lee
force-pushed
the
ignore-not-valid-extension-name-in-cloud-event-deserializer
branch
from
e23463a
to
f06343a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudEventDeserializer by cloudevents-json-jackson throws an exception when an invalid extension key is included.
Since the extension attribute is not a madatory value, why don't CloudEventDeserializer ignore invalid attributes and run Deserialize?
I modified to ignore the invalid extensionName in CloudEventDeserializer.
Fixes #428