Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Implementation of XML Format #448

Merged
merged 13 commits into from
Jan 10, 2023
Merged

Initial Implementation of XML Format #448

merged 13 commits into from
Jan 10, 2023

Conversation

JemDay
Copy link
Contributor

@JemDay JemDay commented Mar 11, 2022

  • I believe this is "spec compliant - I was wring this at the same time I was writing the spec.
  • We may want to consider a streaming parsing implementation at some point, but I'm not sure that's needed now.
  • Contains +ve and -ve tests along with some round-trip verifications.
  • Implementation is contained and not visible outside the package/module.
  • Comments welcome :-)

Closes #446

@pierDipi pierDipi self-requested a review March 17, 2022 15:33
pierDipi
pierDipi reviewed Apr 21, 2022
View reviewed changes
docs/xml.md Outdated Show resolved Hide resolved
core/src/main/java/io/cloudevents/core/impl/BaseCloudEventBuilder.java Show resolved Hide resolved
formats/xml/src/main/java/io/cloudevents/xml/XMLDeserializer.java Outdated Show resolved Hide resolved
docs/xml.md Outdated Show resolved Hide resolved
formats/xml/pom.xml Outdated Show resolved Hide resolved
formats/xml/src/main/java/io/cloudevents/xml/XMLDeserializer.java Outdated Show resolved Hide resolved
docs/xml.md Show resolved Hide resolved
formats/xml/src/main/resources/META-INF/services/io.cloudevents.core.format.EventFormat Outdated Show resolved Hide resolved
@pierDipi pierDipi self-requested a review April 26, 2022 08:16
pierDipi
pierDipi reviewed Jan 2, 2023
View reviewed changes
kafka/pom.xml Outdated Show resolved Hide resolved
JemDay and others added 11 commits January 3, 2023 08:51
@JemDay
Initial Commit
c5b5cce 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
tweaks
7b306cf 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
More negative tests
71c8e5b 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
More Tests
b78186d 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
Adopted (unratified) chnages to types and namespaces
ba689ae 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
More cleanups
5e833d8 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
reformatting and comment cleanups
4acbd5d 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
Minor tweak to trigger build
91b2b38 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
Add checks for duplicated CE atrtributes in XML document
87b4992 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
Address review comments
9c857c0 
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
JavaDoc now builds, fixed typos
dec4019 
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
Minor docs tweak
492de41 
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
@JemDay
Address Review Comments
de0442f 
Signed-off-by: Jem Day <Jem.Day@cliffhanger.com>
pierDipi
pierDipi reviewed Jan 9, 2023
View reviewed changes
formats/xml/src/main/java/io/cloudevents/xml/XMLUtils.java

class XMLUtils {

private static final Pattern XML_PATTERN = Pattern.compile("^(application|text)\\/([a-zA-Z]+\\+)?xml(;.*)*$");
private static final Pattern TEXT_PATTERN = Pattern.compile("^application\\/([a-zA-Z]+\\+)?(xml|json)(;.*)*$");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're adding json too because it's a common / well known "text-based format", right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ... any text/* content-types are caught in the utility function without using the regex (to keep it simpler!).

pierDipi
pierDipi approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM

@pierDipi pierDipi merged commit 433ec5b into cloudevents:master Jan 10, 2023
@JemDay JemDay deleted the jd-xml branch January 24, 2023 19:40
@astelmashenko astelmashenko mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XML Format Support
2 participants
@JemDay @pierDipi