Cesql v1 fixes #641
Merged
Cesql v1 fixes #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierDipi
reviewed
Jun 19, 2024
sql/src/main/java/io/cloudevents/sql/impl/ExceptionFactoryImpl.java
Outdated
Show resolved
Hide resolved
sql/src/main/java/io/cloudevents/sql/impl/ExceptionFactoryImpl.java
Outdated
Show resolved
Hide resolved
pierDipi
reviewed
Jun 19, 2024
sql/src/main/java/io/cloudevents/sql/impl/runtime/EvaluationResult.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
…hen there may be an error Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
pierDipi
reviewed
Jun 20, 2024
Signed-off-by: Calum Murray <cmurray@redhat.com>
Can you completely remove that link? |
Signed-off-by: Calum Murray <cmurray@redhat.com>
|
Done - can you recheck this @pierDipi |
|
Thanks @Cali0707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the CESQL implementation to pass the v1 spec conformance tests.
The main change in this PR is that now the
EvaluationResulttype is used internally as well as for the final return value of the expressions, instead of using a thrower interface to collect errors over time. This allows for handling of specific exceptions that are encountered in subexpressions (for example, missing attributes). Outside of that, there are various small fixes to get the SDK to match the v1 spec.I tried to organize my work by commit, but since I wanted to get everything to pass before I did that I only sort of managed to do that. So, the commits are generally organized by what changed in them, but there may be some extra stuff in each commit. Sorry about that!
cc @pierDipi @matzew
Fixes #618