Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CloudEventValidatorProvider thread safe #650

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jul 2, 2024

Fixes #643

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi added the bug Something isn't working label Jul 2, 2024
@pierDipi
Copy link
Member Author

pierDipi commented Jul 2, 2024

@flebastard can you take a look?

@pierDipi
Copy link
Member Author

pierDipi commented Jul 2, 2024

cc @touchkey

@flebastard
Copy link

@flebastard can you take a look?

Hi, LGTM as the ServiceLoader.load() is called only once when the singleton is created

@pierDipi pierDipi merged commit 4c5d0ef into cloudevents:main Jul 2, 2024
5 checks passed
@pierDipi pierDipi deleted the validator-thread-safe branch July 2, 2024 15:39
pierDipi added a commit to pierDipi/sdk-java that referenced this pull request Jul 2, 2024
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit that referenced this pull request Jul 2, 2024
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot invoke "java.lang.ClassLoader.getParent()" because "this.currentLoader" is null
2 participants