Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batched Content Mode #45

Closed
achille-roussel opened this issue Feb 1, 2020 · 6 comments
Closed

Batched Content Mode #45

achille-roussel opened this issue Feb 1, 2020 · 6 comments
Labels
status/no-issue-activity status/stalled Issues that have not made progress recently type/question Further information is requested

Comments

@achille-roussel
Copy link

Hello,

I wanted to ask if a plan to support Batched Content Mode was in the work?
@fabiojose fabiojose added good first issue Good for newcomers type/question Further information is requested labels Feb 13, 2020
@fabiojose
Copy link
Contributor

It's comming! But, could be faster if you help us with a nice PR!

@achille-roussel
Copy link
Author

achille-roussel commented Feb 13, 2020 •
edited
Loading

Fair point, I mostly didn’t want to duplicate work if it was already inflight.

If I find time to contribute I’ll post an update on this issue 👍

@fabiojose
Copy link
Contributor

Go ahead! We are looking forward for your PR.

@achille-roussel
Copy link
Author

The HTTP bindings for CloudEvents are simple enough to implement that I ended up just writing custom code to support my use case instead of taking a dependency on this package, so I don't have much incentives to contribute to this package anymore.

Thanks for following up tho!

@lance
Copy link
Member

lance commented May 9, 2020

@achille-roussel if you feel like submitting a pull request with support for batch mode, that would be great! For now, marking this as stalled and we can revisit as the SDK evolves.

@lance lance added status/stalled Issues that have not made progress recently and removed good first issue Good for newcomers labels May 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2020

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/no-issue-activity status/stalled Issues that have not made progress recently type/question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lance @achille-roussel @fabiojose