Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the release-please automation script. #554

Merged
merged 1 commit into from
May 31, 2023

Conversation

lholmquist
Copy link
Contributor

@lholmquist lholmquist commented May 31, 2023

The id of release was left out, so the checks to see if there needs to be a publish were being skipped

see https://github.com/cloudevents/sdk-javascript/actions/runs/5133682126/jobs/9236610689

The id of release was left out, so the checks to see if there needs to be a publish were being skipped

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist requested a review from lance May 31, 2023 14:03
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that this is not in the release-please-action docs. But I see what you mean.

@lance lance merged commit 023171d into cloudevents:main May 31, 2023
@lholmquist lholmquist deleted the fix_automation_of_publish branch July 11, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants