Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pull_request_template.md #3

wants to merge 1 commit into from

Conversation

josisusan
Copy link

@josisusan josisusan commented Sep 23, 2020

Jira Link:

Component Name:

Summary/Motivation:

Documentation:

Testing Strategy:

Dependencies:

Screenshots and GIF:

Deployment Strategy:

Pull Request Guidelines

Add checklist for the following list:
- Adding Changelog
- Update service-version
- Update config-version
@josisusan
Copy link
Author

Changes:

  • Adding Changelog
  • Update service-version
  • Update config-version

Comment on lines +16 to +18
- [ ] Add Changelog
- [ ] Update Service version
- [ ] Update Config version
Copy link

@milap-neupane milap-neupane Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Add Changelog
- [ ] Update Service version
- [ ] Update Config version
- [ ] 🗄️ I have added the Changelog
- [ ] 📦 I have updated the Service version
- [ ] 🔧 I have updated the Config version
- [ ] ⚡ I have tested performance of lambda api endpoint using Jaeger trace

@barunthapa
Copy link
Contributor

Need to update the template file that is in the root folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants