Add Contains() function

[allenluce]

This function shortcuts the normal process of finding strings, exiting early on the first string match. This can give a practical speed-up in cases where only existence of any string matters.

[client9]

Hi @allenluce the only change i would make is to make the comment more "go doc/golint" friendly.

ahocorasick.go:259:1: exported method Matcher.Contains should have comment or be unexported

i.e..

// Contains returns true if any string matches.  It can be faster if you
// do not need to know which words matched.
func (m *Matcher) Contains(in []byte) bool {

I'll see if I can track down the repo owner.

[client9]

Hi again @allenluce , he's on twitter with the same name @jgrahamc if you want to ping him. Github notifications aren't so great and easy for things to get lost.

[client9]

FWIW: since I'm paranoid, I added a Contains check to every other existing test case, and it passed. Good work @allenluce

[allenluce]

Yup. I'd done the same thing myself.

[client9]

That last change might have been too aggressive @allenluce

on my box this fails:

func TestContains(t *testing.T) {
        m := NewStringMatcher([]string{"SupermanX", "per"})
        ok := m.Contains([]byte("The Man Of Steel: Superman"))
        assert(t, ok == true)
}

[client9]

Going back to your first implimentation https://github.com/allenluce/ahocorasick/blob/bae7daa5dcf283972e143516e7da54d1d04242d9/ahocorasick.go works

[allenluce]

OK. I pulled that back and squashed commits.

[allenluce]

Is this something that might be merged in?

[nanmu42]

Hi, I find this feature very useful, I wonder what is the latest status of this PR?

[client9]

hi @nanmu42 see https://github.com/signalsciences/ac the Match and MatchString does the "contains"

[allenluce]

Is there a replacement or substitute for this?

[jgrahamc]

If someone could fix the pull request to merge I'd look at it.