Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ToOwned for X509StoreRef and Clone for X509Store #108

Merged
merged 1 commit into from
May 11, 2023
Merged

Implement ToOwned for X509StoreRef and Clone for X509Store #108

merged 1 commit into from
May 11, 2023

Conversation

nox
Copy link
Collaborator

@nox nox commented Mar 27, 2023

No description provided.

@nox
Copy link
Collaborator Author

nox commented Mar 27, 2023

Apparently clang-7 was removed from Ubuntu 22.04?

@nox nox force-pushed the store-clone branch 3 times, most recently from 3b0b925 to 85b2f20 Compare March 27, 2023 11:15
@inikulin inikulin merged commit 1c1af4b into cloudflare:master May 11, 2023
nox added a commit to nox/boring that referenced this pull request May 15, 2023
@nox
Revert "Merge pull request cloudflare#108 from nox/store-clone"
5c68b38 
This reverts commit 1c1af4b, reversing
changes made to da32be1.

SslContextBuilder::cert_store_mut returns a &mut X509StoreBuilder
backed by a X509Store that is already shared with an existing SslContext.
nox added a commit to nox/boring that referenced this pull request May 15, 2023
@nox
Revert "Merge pull request cloudflare#108 from nox/store-clone"
6e751e8 
This reverts commit 1c1af4b, reversing
changes made to da32be1.

SslContextBuilder::cert_store_mut returns a &mut X509StoreBuilder
backed by a X509Store that is already shared with an existing SslContext.
inikulin added a commit that referenced this pull request Jul 3, 2023
@inikulin
Merge pull request #120 from nox/revert
8f48855 
Revert "Merge pull request #108 from nox/store-clone"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghedo ghedo ghedo approved these changes

@inikulin inikulin inikulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nox @ghedo @inikulin