Provide into_ssl() for ConnectConfiguration #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
reviewed
Sep 19, 2023
boring/src/ssl/connector.rs
Outdated
Comment on lines
197
to
209
| if self.sni && domain.parse::<IpAddr>().is_err() { | ||
| self.ssl.set_hostname(domain)?; | ||
| } | ||
|
|
||
| if self.verify_hostname { | ||
| setup_verify_hostname(&mut self.ssl, domain)?; | ||
| } |
There was a problem hiding this comment.
Those checks are different than in connect below, they should be the same and connect should call into_ssl.
There was a problem hiding this comment.
Updated. I keep the && domain.parse::<IpAddr>().is_err() which is a fix ported from openssl-rs.
Port from openssl-rs.
eaufavor
force-pushed
the
connector_into_ssl
branch
from
309628d
to
d905fd3
Compare
nox
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from openssl-rs.