Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kx-safe-default gate on SslCurve #229

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

rushilmehra
Copy link
Collaborator

While setting curves should be restricted by the kx-safe-default feature, reading the curve is allowed.

Copy link
Collaborator

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposing the SSL curves list is fine, but we still want to prevent the user from setting the curves list if the "kx-*" feature flags are in use. This is because the features will silently overwrite the user's preference.

While setting curves should be restricted by the kx-safe-default
feature, reading the curve is allowed.
@rushilmehra rushilmehra merged commit 167f5ae into master Mar 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants