Fix SSL curve identifiers #239
Merged
+46
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwesterb
approved these changes
Jun 3, 2024
|
This breaks |
Some functions use the NID_* constants, and some use the SSL_CURVE_* ones. Extract from the documentation: > Where NIDs are unstable constants specific to OpenSSL and BoringSSL, group IDs are defined by the TLS protocol. Prefer the group ID representation if storing persistently, or exporting to another process or library.
bwesterb
approved these changes
Jun 3, 2024
|
CI is borked, I'm trying to fix it in #240. Let's hold off on merging this until CI is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing I noticed that
SslRef::curve()was returning29(SSL_CURVE_X25519) instead of948(NID_X25519).I assume most users rely on
SslCurve::name()which is correct because it's passing the id back to the ffi layer.