Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make certmgr only look for *.json, *.yaml or *.yml files in certmgr.d dir #33

Closed
jordiclariana opened this issue Nov 9, 2017 · 0 comments · Fixed by #34
Closed

Make certmgr only look for *.json, *.yaml or *.yml files in certmgr.d dir #33

jordiclariana opened this issue Nov 9, 2017 · 0 comments · Fixed by #34

Comments

@jordiclariana
Copy link
Contributor

To avoid problems with temporal files, as when I'm editing some file in that directory:

# ./certmgr-linux-amd64-v1.4.2 
2017/11/09 15:40:33 [INFO] certmgr: loading from config file /etc/certmgr/certmgr.yaml
2017/11/09 15:40:33 [INFO] manager: loading certificates from/etc/certmgr.d
2017/11/09 15:40:33 [INFO] manager: loading spec from /etc/certmgr.d/.test.json.swp
2017/11/09 15:40:33 [FATAL] certmgr: cert: unrecognised spec file format for /etc/certmgr.d/.test.json.swp
kisom added a commit that referenced this issue Nov 9, 2017
@kisom
A collection of minor improvements.
249ace2 
* Only look for valid YAML/JSON files in the cert spec
  dir (e.g. fix #33).
* Update Travis to use Go 1.9 to fix a Go bug in the
  user lookups (#30).
* Update README to include CA file path writing.
* Remove the informational message about not writing a CA file
  if no file path was provided. This was useful in testing,
  but has caused a great deal of confusion among users.
* Bump the patch version to trigger a release using the new Go version.

Use Go-1.9 and add CA file writes to README.
@kisom kisom mentioned this issue Nov 9, 2017
Merged
@kisom kisom closed this as completed in #34 Nov 9, 2017
kisom added a commit that referenced this issue Nov 9, 2017
@kisom
A collection of minor improvements.
efd35cf 
* Only look for valid YAML/JSON files in the cert spec
  dir (e.g. fix #33).
* Update Travis to use Go 1.9 to fix a Go bug in the
  user lookups (#30).
* Update README to include CA file path writing.
* Remove the informational message about not writing a CA file
  if no file path was provided. This was useful in testing,
  but has caused a great deal of confusion among users.
* Bump the patch version to trigger a release using the new Go version.

Use Go-1.9 and add CA file writes to README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A collection of minor improvements. cloudflare/certmgr
1 participant
@jordiclariana