cmd/generate: Handle rewriting uri.query.value to empty strings
#546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `writeAttrLine` to accept the parent block information and allow us to perform different behaviour based on the ancestry.
Allows customers to strip query string parameters in rewrite rules and ensures cf-terraforming knows it is a special case for empty strings.
jacobbednarz
force-pushed
the
allow-empty-rewrite-rules-to-generate
branch
from
ca4b5c6
to
c108070
Compare
jacobbednarz
force-pushed
the
allow-empty-rewrite-rules-to-generate
branch
from
375fa12
to
2f54c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR achieves two things. The fist, updates
writeAttrLineto accept the parent block information and allow us to perform different behaviour based on the ancestry. The second allows customers to strip query string parameters in rewrite rules and ensurescf-terraformingknows it is a special case for empty strings.