Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Support for 4 new cloudflare_teams_* resources and additional README.md Improvements #669

Merged
merged 14 commits into from Jan 17, 2024
Merged

Adding Support for 4 new cloudflare_teams_* resources and additional README.md Improvements #669

merged 14 commits into from Jan 17, 2024

Conversation

devinbfergy
Copy link
Contributor

@devinbfergy devinbfergy commented Jan 12, 2024 •
edited by jacobbednarz

Adds support for the following

  • cloudflare_teams_list
  • cloudflare_teams_location
  • cloudflare_teams_proxy_endpoint
  • cloudflare_teams_rule

Also the PR adds some information about a suggested way to perform local testing.

Adding the cloudflare_teams_account will need to be done in future MR.

Closes #424

@devinbfergy devinbfergy mentioned this pull request Jan 12, 2024
Closed
jacobbednarz
jacobbednarz reviewed Jan 15, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Jan 15, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Jan 15, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid start! few things to address but overall, looking good. thanks!

devinbfergy and others added 8 commits January 16, 2024 11:57
@devinbfergy @jacobbednarz
Update README.md to be more clear
ba7f4a2 
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
@devinbfergy @jacobbednarz
Update internal/app/cf-terraforming/cmd/generate.go to use reusable i…
0ed43a3 
…dentifier

Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
@devinbfergy @jacobbednarz
Update internal/app/cf-terraforming/cmd/import.go reuse identifier
667dd91 
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
Fixed indentation of code blocks in README.md and instructions for te…
31778f0 
…sting. Also added path for testing to make file
Updating that the env var isn't needed for testing (included in make …
bf213fc 
…file)
go format
3abeffb
Fixed all extra non-need identifier creations to use the main one
c11cbc9
Updated to make the remapping of the object similar to other remap an…
f238937 
…d updated test to example.com
@jacobbednarz jacobbednarz merged commit d7b07df into cloudflare:master Jan 17, 2024
4 checks passed
@jacobbednarz
Copy link
Member

thanks @devinbfergy 👏 looks good from me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add generate support for Cloudflare Teams/Zero Trust resources
2 participants
@devinbfergy @jacobbednarz