Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Inconsistancy between cf-component-input example website and master #74

Closed
manatarms opened this issue Feb 21, 2017 · 2 comments
Closed

Comments

@manatarms
Copy link
Contributor

I noticed that the cf-component-input on the example website is out of date. Specifically the handleChange and constructor functions.
The master build however, shows the correct example. Not sure if this is something to do with a publishing issue.

https://cloudflare.github.io/cf-ui/#cf-component-input

https://github.com/cloudflare/cf-ui/blob/master/packages/cf-component-input/example/basic/component.js

@jwineman
Copy link
Contributor

I'm assuming the build diffs the current example site vs the one in production and doesn't deploy if they're the same. Its possible someone didn't run npm run examples:build:internal before npm run publish.

@wyuenho
Copy link
Contributor

wyuenho commented Feb 22, 2017

We haven't updated the gh-pages branch for a while. The process there is kind of a mess. It's a branch, but has no relation to the master branch. We should probably change the build script to do this to make publishing github pages easier.

wyuenho added a commit that referenced this issue Feb 22, 2017
wyuenho added a commit that referenced this issue Feb 22, 2017
* #74 move github pages to master

* s/dist/docs
@wyuenho wyuenho closed this as completed Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants