This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
chore(tooling): force conventional commits #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyuenho
approved these changes
Jun 22, 2017
|
@koddsson could you update CONTRIBUTING.md with link to https://conventionalcommits.org/ and small explanation why we decided to go with it. |
jwineman
approved these changes
Jun 22, 2017
|
@sejoker Sure! I was thinking about also not merging this until next monday so I can walk through what this change would mean for the team? |
|
@koddsson cool thanks, that would be nice. |
|
I tried this on a different branch and it works like a charm! Didn't prompt me for the change but determined it from the commit.
|
koddsson
force-pushed
the
force-conventional-commits
branch
from
8bc73de
to
6f86651
Compare
added 3 commits
June 26, 2017 16:58
Add the packages `husky` and `validate-commit-msg` to create a precommit git hook that rejects commits that do not adhere to the conventional commits standard[1]. This enables us to run `lerna publish` with the flag `--conventional-commits` which will autogenerate a changelog and set the package versions automatically. This PR enables this flag. [1]: https://conventionalcommits.org/ Closes: cloudflare#237
This dependency will make lerna automatically generate a CHANGELOG based on the conventional commits
koddsson
force-pushed
the
force-conventional-commits
branch
from
6f86651
to
d4acda5
Compare
tajo
approved these changes
Jun 26, 2017
koddsson
pushed a commit
to koddsson/cf-ui
that referenced
this pull request
Jun 28, 2017
It somehow slipped through the cracks in cloudflare#269 to upgrade lerna since it's only the new version that includes conventional commits support. It also seems that `lerna` doesn't push the publish commit so we've added it to the `npm` publish command.
koddsson
added a commit
that referenced
this pull request
Jun 28, 2017
It somehow slipped through the cracks in #269 to upgrade lerna since it's only the new version that includes conventional commits support. It also seems that `lerna` doesn't push the publish commit so we've added it to the `npm` publish command.
koddsson
added a commit
to koddsson/cf-ui
that referenced
this pull request
Jun 28, 2017
It somehow slipped through the cracks in cloudflare#269 to upgrade lerna since it's only the new version that includes conventional commits support. It also seems that `lerna` doesn't push the publish commit so we've added it to the `npm` publish command.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the packages
huskyandvalidate-commit-msgto create a precommitgit hook that rejects commits that do not adhere to the conventional
commits standard1.
This enables us to run
lerna publishwith the flag--conventional-commitswhich will autogenerate a changelog and set thepackage versions automatically. This PR enables this flag.
Closes: #237