Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

/infos returns a blank page #68

Open
skakee opened this issue Oct 7, 2020 · 9 comments
Open

/infos returns a blank page #68

skakee opened this issue Oct 7, 2020 · 9 comments

Comments

@skakee
Copy link

skakee commented Oct 7, 2020

Yesterday, 2020-10-06, I pulled the new versions of the binary with:
go get -u github.com/cloudflare/cfrpki/cmd/octorpki
/infos returns with HTTP code 200 an a zero-byte json doc. /output.json and /metrics return fine. Running on CentOS 8.2:
cloudfl+ 169753 1 3 Oct06 ? 00:33:17 /opt/cloudflare/go/bin/octorpki -mode server -output.sign=false -http.addr :8080

Any ideas as t why?

@lspgn
Copy link
Contributor

lspgn commented Oct 13, 2020

Hi @skakee,
Yes, I temporarily removed the endpoint in the alpha version. The idea is to refactor the API so it returns debugging information.
It will come back. Let me know if you have any requests/suggestions on data to display.

@skakee
Copy link
Author

skakee commented Oct 13, 2020

Thanks! That leads me to another question... if the available binary is "alpha", what is the recommended version I should run an how to obtain it? I'm running on CentOS 8.2.
Thanks again.

P.S. I use /info to check for '"stable":true ' in Nagios monitoring.

@lspgn
Copy link
Contributor

lspgn commented Oct 13, 2020

ah there's a new endpoint for this :/health.
I am a bit late on improving the alpha version, there are some changes I want to integrate but haven't had time yet.
The previous version should be fine: https://github.com/cloudflare/cfrpki/releases/tag/v1.1.4 (but is missing additions like Sentry and HTTPs TAL).

@skakee
Copy link
Author

skakee commented Oct 13, 2020

Got it. Thanks!

@skakee
Copy link
Author

skakee commented Oct 15, 2020

Hi! I just noticed that v1.1.4 is over a year old. Is this really the latest GA release? I know that there was a problem memory management you addressed since then. See: Octo-RPKI process RAM usage #37. That would imply that v1.1.4 still has memory usage issues. And I remember there was an issue with gortr holding on to TCP connections. Does version v0.14.6 on the release page of GoRTR fix that issue?

@lspgn
Copy link
Contributor

lspgn commented Oct 15, 2020

Hello,
Unfortunately, there have been time constrains which resulted in little changes during 2020. I was looking to fix #38, #66 and fix /infos before releasing 1.2.x.
For the GoRTR bug you mentioned: it was fixed with cloudflare/gortr@78f7a6e which is included in 0.14.6.

Don't hesitate if you have more questions or concerns

@skakee
Copy link
Author

skakee commented Oct 15, 2020

Thank you for the clarification. I will continue using my current version of octorpki and wait for an official release of the updated version. I am updating all our rpki servers' gortr to 0.14.6 (from current 0.14.4).

@lspgn lspgn mentioned this issue Oct 24, 2020
@skakee
Copy link
Author

skakee commented Oct 29, 2020

Hi. Above you mention "ah there's a new endpoint for this :/health". Version v1.2.0-pre of the Linux binary also seems to return a blank page for /health.

@lspgn
Copy link
Contributor

lspgn commented Oct 29, 2020

Health should return an empty, code 200 page and text/plain. It can be used by containers healthchecks.
The v1.2.0 has the stable field back in /infos page.
Let me know if that works for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants