Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

TA's tree should've been considered invalid because of invalid signature identifier #66

Closed
job opened this issue Aug 13, 2020 · 3 comments · Fixed by #69
Closed

TA's tree should've been considered invalid because of invalid signature identifier #66

job opened this issue Aug 13, 2020 · 3 comments · Fixed by #69

Comments

@job
Copy link

job commented Aug 13, 2020

Yesterday ARIN introduced incorrect algorithm identifier encodings in their RPKI data.

It appears that for some reason Cloudflare's RPKI validation process did not catch this error and continued to produce VRPs based on cryptographically invalid data

A more detailed analysis of what transpired is available here http://sobornost.net/~job/arin-manifest-issue-2020.08.12.txt

ARIN confirmed the analysis was correct and is now working to restore CA services.

tested on cfrpki 1.2.0-pre

@job
Copy link
Author

job commented Aug 13, 2020

A dump of the broken data is available here http://sobornost.net/~job/arin-broken-state-20200812.tar.gz

the RIR is expected to fix the issue in the next few hours

@lspgn
Copy link
Contributor

lspgn commented Aug 13, 2020

Thanks for raising! I'll try to come up with a fix by next week.

@mahtin
Copy link

mahtin commented Aug 13, 2020

Cross referencing over to NLnetLabs/routinator#365 (comment)

lspgn added a commit that referenced this issue Oct 15, 2020
* reported in #66
* signature identifier in CMS and EE certificate must be the same
* signature identifier must have NULL flag
* requires some hacks in order to check for NULL value (the Go library is flexible on conversion)
@lspgn lspgn closed this as completed in #69 Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants