Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow to run tests on the machine without proper go env #646

Merged
merged 2 commits into from Jul 22, 2016

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Jul 20, 2016

Now all you need are only go and gofmt binaries.

Before test.sh failed with the following msg:

$ ./test.sh 
ls: cannot access /src/github.com/cloudflare/cfssl: No such file or directory

And even with the GOPATH:

$ ./test.sh 
api          cli     Dockerfile          initca     scan       ubiquity
auth         cmd     Dockerfile.build    LICENSE    script     vendor
BUILDING.md  config  Dockerfile.minimal  log        selfsign   whitelist
bundler      crl     errors              multiroot  signer
certdb       crypto  gopath              ocsp       testdata
certinfo     csr     helpers             README.md  test.sh
CHANGELOG    doc     info                revoke     transport
can't load package: package _/home/user/git/cfssl/api: cannot find package "_/home/user/git/cfssl/api" in any of:
        /home/user/go/src/_/home/user/git/cfssl/api (from $GOROOT)
        /home/user/git/cfssl/gopath/src/_/home/user/git/cfssl/api (from $GOPATH)
can't load package: package _/home/user/git/cfssl/api/bundle: cannot find package "_/home/user/git/cfssl/api/bundle" in any of:
        /home/user/go/src/_/home/user/git/cfssl/api/bundle (from $GOROOT)
        /home/user/git/cfssl/gopath/src/_/home/user/git/cfssl/api/bundle (from $GOPATH)

@kayrus kayrus force-pushed the kayrus/test_no_env branch 4 times, most recently from c171378 to 0e8a540 Compare July 20, 2016 11:17
@kayrus kayrus changed the title test: allow to run tests on mathine without proper go env test: allow to run tests on machine without proper go env Jul 20, 2016
@kayrus kayrus changed the title test: allow to run tests on machine without proper go env test: allow to run tests on the machine without proper go env Jul 20, 2016
@codecov-io
Copy link

codecov-io commented Jul 20, 2016

Current coverage is 58.32% (diff: 100%)

Merging #646 into master will not change coverage

@@             master       #646   diff @@
==========================================
  Files            74         74          
  Lines          6402       6402          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           3734       3734          
  Misses         2309       2309          
  Partials        359        359          

Powered by Codecov. Last update 6944eb7...b81a6a9

@kisom
Copy link
Contributor

kisom commented Jul 22, 2016

LGTM, thanks!

@kisom kisom merged commit 6b138b2 into cloudflare:master Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants