Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix headers params #108

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix headers params #108

merged 3 commits into from
Dec 13, 2023

Conversation

rmzaoo
Copy link
Contributor

@rmzaoo rmzaoo commented Dec 13, 2023

No description provided.

Copy link

github-actions bot commented Dec 13, 2023

🧪 A prerelease is available for testing 🧪

You can install this latest build in your project with:

npm install --save https://prerelease-registry.devprod.cloudflare.dev/itty-router-openapi/runs/7197905543/npm-package-itty-router-openapi-108

Or you can immediately run this with npx:

npx https://prerelease-registry.devprod.cloudflare.dev/itty-router-openapi/runs/7197905543/npm-package-itty-router-openapi-108

Copy link
Member

@G4brym G4brym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thanks for this pr, but for this to work you will also need to update the extractParameter function in parameters.ts file
nevermind, this function is not even used anymore, let me manually test your change

@rmzaoo
Copy link
Contributor Author

rmzaoo commented Dec 13, 2023

Hey there, thanks for this pr, but for this to work you will also need to update the extractParameter function in parameters.ts file nevermind, this function is not even used anymore, let me manually test your change

Nice, I had changed it but I've reverted. Thank you 🙏🏻

@rmzaoo rmzaoo closed this Dec 13, 2023
@rmzaoo rmzaoo reopened this Dec 13, 2023
@G4brym G4brym merged commit 0d29ff2 into cloudflare:main Dec 13, 2023
4 checks passed
@G4brym
Copy link
Member

G4brym commented Dec 13, 2023

Thanks for this fix, i've opened a new release (v1.0.6) with your change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants