Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workers]: Update Jamstack Tutorial #11200

Closed
wants to merge 16 commits into from
Closed

[Workers]: Update Jamstack Tutorial #11200

wants to merge 16 commits into from

Conversation

lauragift21
Copy link
Contributor

@lauragift21 lauragift21 commented Oct 10, 2023 •
edited
Loading

Rewrite the tutorial to use Module workers syntax.

closes #14417

@github-actions github-actions bot added the product:workers Related to Workers product label Oct 10, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 10, 2023 •
edited
Loading

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: bcf1240
Status: ✅  Deploy successful!
Preview URL: https://49c3cb98.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://update-jamstack-tutorial.cloudflare-docs-7ou.pages.dev

View logs

@github-actions
Copy link

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/tutorials/build-a-jamstack-app/ https://update-jamstack-tutorial.cloudflare-docs-7ou.pages.dev/workers/tutorials/build-a-jamstack-app/

@lauragift21 lauragift21 force-pushed the update-jamstack-tutorial branch 2 times, most recently from 2818a2c to b4076c3 Compare October 10, 2023 12:19
deadlypants1973
deadlypants1973 requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@deadlypants1973 deadlypants1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor suggestions for style guide. This tutorials needs a peer technical review for the entirety of the tutorial from devrel. For things like code description accuracy, there are a few parts in the tutorial where 'fetch' is being addressed rather than the 'fetch' handler. These are two separate concepts and should be made distinct to avoid confusing users.

content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
content/workers/tutorials/build-a-jamstack-app/index.md Outdated Show resolved Hide resolved
lauragift21 and others added 13 commits January 10, 2024 07:50
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
8988e94 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
fda2e91 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
fac6bd3 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
6c9024f 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
c193cca 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
d4bdfd6 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
58bd7d2 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
5e03d48 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
7fb82ad 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
12d61da 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
b7b550d 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21 @deadlypants1973
Update content/workers/tutorials/build-a-jamstack-app/index.md
9bf63f4 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@lauragift21
Merge branch 'production' into update-jamstack-tutorial
964a06a
@kodster28
Copy link
Contributor

Going to close this out for now as there are conflicts in the underlying file + this hasn't seen any action in a few months.

Feel free to re-open on a new PR though, definitely would be good to see this tutorial updated.

@kodster28 kodster28 closed this Apr 23, 2024
@kodster28 kodster28 mentioned this pull request May 6, 2024
Closed
@lauragift21 lauragift21 reopened this May 10, 2024
@kodster28
Copy link
Contributor

kodster28 commented May 14, 2024 •
edited
Loading

Howdy @lauragift21, you might want to start a new PR with the same branch (the changes requested will block any approvals / merging).

@kodster28 kodster28 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlypants1973 deadlypants1973 deadlypants1973 requested changes

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

Assignees

@irvinebroque irvinebroque

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@deadlypants1973 deadlypants1973

Labels
product:workers Related to Workers product size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build a JAMstack app wrangler 2
6 participants
@lauragift21 @kodster28 @deadlypants1973 @irvinebroque @GregBrimble @WalshyDev