Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions, Deployments, Gradual Deployments #13429

Merged
merged 21 commits into from
Mar 29, 2024
Merged

Versions, Deployments, Gradual Deployments #13429

merged 21 commits into from
Mar 29, 2024

Conversation

tanushree-sharma
Copy link
Contributor

@tanushree-sharma tanushree-sharma commented Mar 14, 2024 •
edited

Documentation for Versions, Deployments, Gradual Deployments closed beta.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

  • /workers/configuration/deployments/

@github-actions github-actions bot added size/m product:workers Related to Workers product labels Mar 14, 2024
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Mar 14, 2024 •
edited

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6bfcf96
Status: ✅  Deploy successful!
Preview URL: https://b395d18a.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://gradual-deployments.cloudflare-docs-7ou.pages.dev

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/wrangler/commands/ https://gradual-deployments.cloudflare-docs-7ou.pages.dev/workers/wrangler/commands/
https://developers.cloudflare.com/workers/configuration/versions-and-deployments/gradual-deployments/ https://gradual-deployments.cloudflare-docs-7ou.pages.dev/workers/configuration/versions-and-deployments/gradual-deployments/
https://developers.cloudflare.com/workers/configuration/deployments/ https://gradual-deployments.cloudflare-docs-7ou.pages.dev/workers/configuration/deployments/
https://developers.cloudflare.com/workers/configuration/versions-and-deployments/ https://gradual-deployments.cloudflare-docs-7ou.pages.dev/workers/configuration/versions-and-deployments/
https://developers.cloudflare.com/workers/configuration/versions-and-deployments/rollbacks/ https://gradual-deployments.cloudflare-docs-7ou.pages.dev/workers/configuration/versions-and-deployments/rollbacks/
https://developers.cloudflare.com/workers/runtime-apis/bindings/version-metadata/ https://gradual-deployments.cloudflare-docs-7ou.pages.dev/workers/runtime-apis/bindings/version-metadata/
https://developers.cloudflare.com/workers/reference/migrate-to-module-workers/ https://gradual-deployments.cloudflare-docs-7ou.pages.dev/workers/reference/migrate-to-module-workers/
https://developers.cloudflare.com/learning-paths/workers/configure/intro-to-config/ https://gradual-deployments.cloudflare-docs-7ou.pages.dev/learning-paths/workers/configure/intro-to-config/

irvinebroque
irvinebroque reviewed Mar 19, 2024
View reviewed changes
content/workers/configuration/versions-and-deployments/gradual-deployments.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/gradual-deployments.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/gradual-deployments.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/rollbacks.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/rollbacks.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/rollbacks.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/rollbacks.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/rollbacks.md Outdated Show resolved Hide resolved
tanushree-sharma and others added 2 commits March 19, 2024 14:55
@tanushree-sharma @irvinebroque
Apply suggestions from code review
c3973b1 
Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>
@tanushree-sharma
wrangler commands & feedback
69b31d3
@github-actions github-actions bot added size/l and removed size/m labels Mar 20, 2024
tanushree-sharma and others added 2 commits March 28, 2024 00:57
@tanushree-sharma
wrangler commands and edits
cc4399a
@tanushree-sharma @deadlypants1973 @irvinebroque
Apply suggestions from code review
82bcaf5 
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>
@RamIdeas RamIdeas mentioned this pull request Mar 28, 2024
Merged
9 tasks
deadlypants1973
deadlypants1973 reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@deadlypants1973 deadlypants1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PCX final pt.1

content/workers/configuration/versions-and-deployments/_index.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/_index.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/_index.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/_index.md

## Deployments

Deployments track the version(s) of your Worker that are actively serving traffic. A deployment can consist of one or two versions of a Worker.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's also something about technicality to consider on Brendan's suggestion. If a version is not serving traffic in that moment, is it not a version? Thinking about in the unlikely event of an outage. Maybe "currently deployed on Cloudflare's network" is the most accurate and objective we could get. But I'm good either option you choose.

content/workers/configuration/versions-and-deployments/_index.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/rollbacks.md Outdated Show resolved Hide resolved
content/workers/configuration/versions-and-deployments/rollbacks.md Outdated Show resolved Hide resolved
content/workers/wrangler/commands.md Show resolved Hide resolved
content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
deadlypants1973
deadlypants1973 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@deadlypants1973 deadlypants1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PCX final pt. 2

content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
content/workers/wrangler/commands.md Show resolved Hide resolved
content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
content/workers/wrangler/commands.md Show resolved Hide resolved
content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
content/workers/wrangler/commands.md Outdated Show resolved Hide resolved
@RamIdeas RamIdeas mentioned this pull request Mar 28, 2024
Merged
9 tasks
@jp4a50 @irvinebroque @tanushree-sharma
Add gradual deployments documentation the Cf-Worker-Version-Key hea…
92f7748 
…der. (#13554)

* Add documentation for the `Cf-Worker-Version-Key` header.

* Apply suggestions from code review

* Update content/workers/configuration/versions-and-deployments/gradual-deployments.md

* Apply suggestions from code review

Co-authored-by: Tanushree <87711021+tanushreesharma-cf@users.noreply.github.com>

* Add example of using a request header modification rule to set
Cloudflare-Workers-Version-Key.

---------

Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>
Co-authored-by: Tanushree <87711021+tanushreesharma-cf@users.noreply.github.com>
@irvinebroque
Copy link
Contributor

Do analytics docs need updates to reflect version field? Logpush / Trace Events docs? To highlight breaking down metrics by version?

@tanushree-sharma
Copy link
Contributor Author

Do analytics docs need updates to reflect version field? Logpush / Trace Events docs? To highlight breaking down metrics by version?

Yes, but minor. Merging this PR since it's needed for tomorrow's wrangler release. Will follow up with additions in a separate PR.

@tanushree-sharma tanushree-sharma merged commit 7b7531e into production Mar 29, 2024
7 checks passed
@tanushree-sharma tanushree-sharma deleted the gradual-deployments branch March 29, 2024 05:35
@tanushree-sharma tanushree-sharma changed the title [do not merge] Versions, Deployments, Gradual Deployments Versions, Deployments, Gradual Deployments Mar 29, 2024
@deadlypants1973 deadlypants1973 mentioned this pull request Apr 1, 2024
Merged
cmsparks pushed a commit that referenced this pull request Apr 1, 2024
@tanushree-sharma @irvinebroque
@jp4a50 @deadlypants1973 @aaronlisman @cmsparks
[do not merge] Versions, Deployments, Gradual Deployments (#13429)
ec14196 
* wip-deployments-update

* first pass at docs

* Apply suggestions from code review

Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>

* wrangler commands & feedback

* Apply suggestions from code review

Co-authored-by: Jon Phillips <jonap2811@gmail.com>

* Apply suggestions from code review

Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>

* ESM limitation, wrangler updates

* Apply suggestions from code review

Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>

* Document gradual deployment benefit of ESM format

Link to gradual deployments docs from "Migrate to ESM" page

* [Workers] Remove note about D1 limitations with rollbacks (#13579)

* wrangler commands and edits

* Apply suggestions from code review

Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>

* Apply suggestions from code review

PCX review

* PCX edits

* edits

* redirects

* Add gradual deployments documentation the `Cf-Worker-Version-Key` header. (#13554)

* Add documentation for the `Cf-Worker-Version-Key` header.

* Apply suggestions from code review

* Update content/workers/configuration/versions-and-deployments/gradual-deployments.md

* Apply suggestions from code review

Co-authored-by: Tanushree <87711021+tanushreesharma-cf@users.noreply.github.com>

* Add example of using a request header modification rule to set
Cloudflare-Workers-Version-Key.

---------

Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>
Co-authored-by: Tanushree <87711021+tanushreesharma-cf@users.noreply.github.com>

* fixes

* keywords, broken link fixes

* redirect fix

---------

Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>
Co-authored-by: Jon Phillips <jonap2811@gmail.com>
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
Co-authored-by: aaronlisman <83968625+aaronlisman@users.noreply.github.com>
Co-authored-by: Kate Tungusova <ktungusova@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvinebroque irvinebroque irvinebroque left review comments

@RamIdeas RamIdeas RamIdeas left review comments

@JoshuaClaeys JoshuaClaeys JoshuaClaeys left review comments

@github-actions github-actions[bot] github-actions left review comments

@ocsi26 ocsi26 ocsi26 left review comments

@deadlypants1973 deadlypants1973 deadlypants1973 approved these changes

@jp4a50 jp4a50 jp4a50 left review comments

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@jasnell jasnell Awaiting requested review from jasnell

@kodster28 kodster28 Awaiting requested review from kodster28 kodster28 is a code owner

Assignees

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@deadlypants1973 deadlypants1973

Labels
product:learning-paths product:_redirects product:workers Related to Workers product size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@tanushree-sharma @irvinebroque @RamIdeas @JoshuaClaeys @ocsi26 @deadlypants1973 @jp4a50 @GregBrimble @WalshyDev @aaronlisman