-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve pages Hono guide #7410
Fix and improve pages Hono guide #7410
Conversation
@yusukebe please give this PR a review if you want 🙂 |
Thanks for looking out for Hono! I am glad. I am just now thinking about the use of Hono on Pages. There is much more that is not covered in this document. In addition to transpiling to But, it is difficult to create new content that includes them right now. We will create another PR when the time comes. Looks good for this PR. Thanks! |
Thanks for the approval @yusukebe 😃 regarding other stuff yeah I understand but if you look at the pages framework guides https://developers.cloudflare.com/pages/framework-guides/ you can see that they are all very minimalistic and just tell you basically how to get started with the various frameworks, so I don't think we should anyways include too much content here, if we can find a way to shortly give the general idea of what Hono can do (for example by adding things in the initial app boilerplate) I think that would be totally fine, but maybe not much more than that (I think) If you want to have a more descriptive document showcasing various cool things that Hono can do maybe there is some other place in which we could provide that? (and potentially linking to that place in the guide?) (I think that even a blog post in the Cloudflare blog would be pretty cool, I'd definitely like try to help out with that 🙂) |
Thanks for the advice. It's sure better not to write a lot of stuff.
Yes, we are planning to renew the website of Hono ( https://honojs.dev ) when releasing the next major version. It's appropriate there.
Wow, that's super cool! No, ultra cool! |
38cd4b3
to
20dfd5a
Compare
@deadlypants1973 Thanks so very much for the awesome reviewing 🙂 (and sorry about the silly mistakes 😅) I've accepted all your suggestions 🙂👍 |
Hi, I'd like to add my thoughts on @yusukebe's proposal here. Regarding the JSX middlware, it sounds to me a non-fundamental topic that doesn't need to be covered in Cloudflare's domain. On the other hand, what is referred to "as an API for SPAs in Adapters, which were proposed in honojs/hono#802 and implemented in honojs/hono#807, make it way easier to integrate Hono into Pages like this: import { Hono } from "hono";
import { handle } from "hono/cloudflare-pages";
const app = new Hono();
// implement requests handling here
export const onRequest = handle(app); With this feature, you don't need to set up build scripts yourself. All you have to do is just run a single Since this feature is not in stable releases now (only in v3 RC), we need to consider when to ship a document describing adapters but it would definitely be a nice-to-have! |
4010c03
to
010a5f5
Compare
Improve the Hono guide by fixing present wrong statements, clarifying others, providing the option to use typescript as well as javascript and also renaming Honojs to Hono (since afaict that's the correct name)
f834378
to
a0e4b7a
Compare
Improve the Hono guide by fixing present wrong statements, clarifying others, providing the option to use typescript as well as javascript and also renaming Honojs to Hono (since afaict that's the correct name)