feat(client): allow binary returns

cloudflare · Nov 3, 2023 · 3405391 · 3405391
1 parent 583ed98
commit 3405391
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/internal/requestconfig/requestconfig.go b/internal/requestconfig/requestconfig.go
@@ -270,6 +270,12 @@ func (cfg *RequestConfig) Execute() (err error) {
 	if cfg.ResponseBodyInto == nil {
 		return nil
 	}
+
+	if responseBodyInto, ok := cfg.ResponseBodyInto.(**http.Response); ok {
+		*responseBodyInto = res
+		return nil
+	}
+
 	contents, err := io.ReadAll(res.Body)
 	if err != nil {
 		return fmt.Errorf("error reading response body: %w", err)

diff --git a/zone_test.go b/zone_test.go
@@ -130,14 +130,14 @@ func TestZoneListWithOptionalParams(t *testing.T) {
 }
 
 func TestZoneDelete(t *testing.T) {
+	t.Skip("body parameter is required")
 	baseURL := "http://localhost:4010"
 	if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
 		baseURL = envURL
 	}
 	if !testutil.CheckTestServer(t, baseURL) {
 		return
 	}
-	t.Skip("body parameter is required")
 	client := cloudflare.NewClient(
 		option.WithBaseURL(baseURL),
 		option.WithAPIKey("my-cloudflare-api-key"),

diff --git a/zonesetting_test.go b/zonesetting_test.go
@@ -36,14 +36,14 @@ func TestZoneSettingList(t *testing.T) {
 }
 
 func TestZoneSettingEdit(t *testing.T) {
+	t.Skip("oneOf doesnt match")
 	baseURL := "http://localhost:4010"
 	if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
 		baseURL = envURL
 	}
 	if !testutil.CheckTestServer(t, baseURL) {
 		return
 	}
-	t.Skip("oneOf doesnt match")
 	client := cloudflare.NewClient(
 		option.WithBaseURL(baseURL),
 		option.WithAPIKey("my-cloudflare-api-key"),