Skip to content

Commit

Permalink
dns: allow filtering ListDNSRecord calls by priority
Browse files Browse the repository at this point in the history
Even though this doesn't make it to the API, we still use it internally
for filtering.
  • Loading branch information
jacobbednarz committed Jan 4, 2023
1 parent 4cc0441 commit a7b8640
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions dns.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ type ListDNSRecordsParams struct {
Order string `url:"order,omitempty"`
Direction ListDirection `url:"direction,omitempty"`
Match string `url:"match,omitempty"`
Priority *uint16 `json:"priority,omitempty"`

This comment has been minimized.

Copy link
@favonia

favonia Jan 5, 2023

Contributor

@jacobbednarz Should it be url: instead of json:? Or maybe having both json: and url:? I noticed that this commit is adding Priority= (capitalized and with no values) to the URL.

This comment has been minimized.

Copy link
@jacobbednarz

jacobbednarz Jan 5, 2023

Author Member

for the URL part, this should be url:"-" as the API doesn't support this filtering and it is done in the Terraform provider.

while annoying, it will be a noop for sending this parameter as is.


ResultInfo
}
Expand Down

0 comments on commit a7b8640

Please sign in to comment.