Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility date and compatibility_flags to pages deployment configs #1051

Merged

Conversation

Cyb3r-Jak3
Copy link
Contributor

Description

Adds compatibility date and compatibility flags to pages deployments
Also fixes a couple cases where errors.New(fmt.Sprintf()) was being used instead of fmt.Errorf()

Has your change been tested?

Updated unit tests and they pass

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs. (soon)

@github-actions
Copy link
Contributor

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1051 (01fbe8c) into master (6c5ea4a) will increase coverage by 0.67%.
The diff coverage is 62.86%.

@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
+ Coverage   49.06%   49.73%   +0.67%     
==========================================
  Files         108      115       +7     
  Lines       10428    10965     +537     
==========================================
+ Hits         5116     5453     +337     
- Misses       4200     4347     +147     
- Partials     1112     1165      +53     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
ip_list.go 33.00% <0.00%> (ø)
list.go 25.00% <0.00%> (ø)
pages_project.go 50.81% <ø> (ø)
workers_account_settings.go 35.71% <35.71%> (ø)
rulesets.go 35.09% <47.36%> (+7.43%) ⬆️
workers_tail.go 52.00% <52.00%> (ø)
workers_subdomain.go 57.14% <57.14%> (ø)
email_routing_settings.go 60.00% <60.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@WalshyDev
Copy link
Member

Just put up the PR for API docs

@jacobbednarz
Copy link
Member

awesome stuff @Cyb3r-Jak3. the API docs will be released early next week but i've confirmed in staging that the API matches what we're after here.

@jacobbednarz jacobbednarz merged commit fed21d7 into cloudflare:master Aug 19, 2022
@github-actions github-actions bot added this to the v0.48.0 milestone Aug 19, 2022
github-actions bot pushed a commit that referenced this pull request Aug 19, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.48.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@Cyb3r-Jak3 Cyb3r-Jak3 deleted the compatibily-in-pages-project branch August 22, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants