Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api shield configuration GET/PUT #1059

Merged
merged 7 commits into from
Aug 25, 2022
Merged

Add api shield configuration GET/PUT #1059

merged 7 commits into from
Aug 25, 2022

Conversation

jafowler
Copy link
Contributor

Description

This PR adds support for API shield configuration GET/PUT requests.
This is needed to help support more products under the Http Applications umbrella.

Has your change been tested?

I wrote some tests for both GET and PUT. Can add more if needed.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.https://api.cloudflare.com/#api-shield-settings-properties

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2022

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #1059 (9da8f52) into master (e39278e) will increase coverage by 0.00%.
The diff coverage is 53.84%.

@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   49.94%   49.95%           
=======================================
  Files         115      116    +1     
  Lines       10991    11017   +26     
=======================================
+ Hits         5490     5504   +14     
- Misses       4338     4346    +8     
- Partials     1163     1167    +4     
Impacted Files Coverage Δ
api_shield.go 53.84% <53.84%> (ø)
r2_bucket.go 100.00% <0.00%> (ø)
teams_accounts.go 53.84% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jafowler
Copy link
Contributor Author

Just saw https://github.com/cloudflare/cloudflare-go/blob/master/docs/experimental.md, will work to update this to follow the doc.

api_shield.go Outdated Show resolved Hide resolved
jafowler and others added 3 commits August 24, 2022 20:40
@jacobbednarz
Copy link
Member

thanks @jafowler - looks good!

@jacobbednarz jacobbednarz merged commit c0c5c42 into master Aug 25, 2022
@jacobbednarz jacobbednarz deleted the add-api-shield branch August 25, 2022 03:37
@github-actions github-actions bot added this to the v0.49.0 milestone Aug 25, 2022
@jafowler
Copy link
Contributor Author

Thanks @jacobbednarz for cleaning up the tests, i'll follow that for the next few resources i'll be adding.

@github-actions
Copy link
Contributor

This functionality has been released in v0.49.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants