Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: don't send unsupported "priority" field for list operations #1167

Merged

Conversation

jacobbednarz
Copy link
Member

Noticed at a7b8640#r95124059 but isn't actually used by the API.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1167 (db0830c) into master (6153c1e) will decrease coverage by 0.12%.
The diff coverage is 46.94%.

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
- Coverage   49.40%   49.28%   -0.13%     
==========================================
  Files         127      128       +1     
  Lines       12290    12416     +126     
==========================================
+ Hits         6072     6119      +47     
- Misses       4840     4896      +56     
- Partials     1378     1401      +23     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
cloudflare_experimental.go 0.00% <0.00%> (ø)
utils.go 72.72% <ø> (ø)
cloudflare.go 68.37% <14.28%> (-0.34%) ⬇️
mtls_certificates.go 26.59% <26.59%> (ø)
origin_ca.go 57.26% <90.90%> (-2.09%) ⬇️
dns.go 68.69% <92.45%> (+4.97%) ⬆️
email_routing_destination.go 66.66% <100.00%> (+0.41%) ⬆️
email_routing_rules.go 65.64% <100.00%> (+0.26%) ⬆️
filter.go 43.38% <100.00%> (+0.41%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 39a4163 into cloudflare:master Jan 6, 2023
@github-actions github-actions bot added this to the v0.59.0 milestone Jan 6, 2023
@jacobbednarz jacobbednarz deleted the ignore-priority-for-url-params branch January 6, 2023 01:06
github-actions bot pushed a commit that referenced this pull request Jan 6, 2023
ivan-section-io pushed a commit to section/cloudflare-go that referenced this pull request Jan 12, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.59.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants