Implement ListOrganizations #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you point out the preferred approach? Thanks |
|
Hi @gliptak - thanks for this! Pagination we've discussed a bit in #6 and #78. It's going to be a breaking change to implement it so it's probably worth doing everything at once. I've got a WIP I'm testing at the moment but needs a bit more work before I submit it. For now I think this PR is OK. I recently updated the |
jamesog
approved these changes
Jan 13, 2017
| // OrganizationResponse represents the response from the Organization endpoint. | ||
| type OrganizationResponse struct { | ||
| // organizationResponse represents the response from the Organization endpoint. | ||
| type organizationResponse struct { | ||
| Response | ||
| Result []Organization `json:"result"` | ||
| ResultInfo ResultInfo `json:"result_info"` |
There was a problem hiding this comment.
Go lets you omit the second ResultInfo here but I'm OK either way having it or not.
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35
@jamesog @elithrar Please review and guide on pagination.
One thought would be to rename
ResultInfotoPaginatorand add a second method signature taking inPaginator. Or variadic args as per #4 ?Thanks