[feat] Load Balancers, User LB Monitors, User LB Pools #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tenzer
approved these changes
Aug 1, 2017
jamesog
reviewed
Aug 1, 2017
README.md
Outdated
| @@ -34,6 +34,7 @@ The current feature list includes: | |||
| - [ ] [Railgun](https://www.cloudflare.com/railgun/) administration | |||
| - [ ] [Keyless SSL](https://blog.cloudflare.com/keyless-ssl-the-nitty-gritty-technical-details/) | |||
| - [x] [Origin CA](https://blog.cloudflare.com/universal-ssl-encryption-all-the-way-to-the-origin-for-free/) | |||
| - [x] Load Balancing (user pools and monitors only) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Linked to the blog post - the marketing page is too concise for my liking!
|
I like the org approach. Less API surface, and clearer intent. Add to the PR, @cbranch - ? |
Implemented by creating the API object with an 'Organization' option. The supposition is that API users probably only care about updating zones within a single scope, so creating separate APIs for both organization and account is unnecessary.
|
Added a bug fix when modifying load balancers that use Automatic TTLs. |
jamesog
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion for how we may support organization-level pools and monitors is presented in the load-balancing-org branch (and possibly, how to support the same for Railguns)