firewall_rule: Fix the ability to delete multiple rules #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the internals of `DeleteFirewallRules` to build the correct query string parameters for deleting multiple rules in a single request. Closes cloudflare#565
patryk
approved these changes
Jan 20, 2021
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the internals of
DeleteFirewallRulesto build the correctquery string parameters for deleting multiple rules in a single request.
I attempted the following without any luck:
?id=abc123,def456?id[]=abc123&id[]=def456DELETE /zones/:zone_id/firewall/ruleswith a payload of[{"id":"abc123"},{"id":"def456"}]The first option was the initial version that worked however it looks like the
API has moved on to another method which we now support here.
Closes #565