Add txt_name & txt_value fields (DNS validation) to CustomHostname struct #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ruct Signed-off-by: Callum Loh <callumloh@gmail.com>
|
unit tests please. you should be able to update existing HTTP mock responses and assert the struct values match. |
Signed-off-by: Callum Loh <callumloh@gmail.com>
|
Added! |
|
Note I've added it as a seperate test as all the other tests used HTTP validation. |
|
thanking you! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds txt_name and txt_value fields to CustomHostname struct that are needed for SSL Verification when using the txt method
Has your change been tested?
No unit tests yet. Unsure if needed.
Types of changes
What sort of change does your code introduce/modify?
Checklist: