Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change certificate validation method #679

Merged

Conversation

TheSkorm
Copy link

@TheSkorm TheSkorm commented Jul 30, 2021

Hello, first time contributor and novice go programmer. Let me know if there are any changes / tasks that need to be completed and I'll get on them ASAP.

Description

This adds the ability to change the certificate validation method for universal ssl. Having the option to change validation method opens up the possibility of implementing changes required to fix the following this cloudflare terraform provider issue.

Has your change been tested?

universal_ssl_test.go has been updated with a test that matches the API documentation. I've also tested in this in a simple go app:

	want := cloudflare.UniversalSSLCertificatePackValidationMethodSetting{
		ValidationMethod: "txt",
	}

	ver, err := api.EditUniversalSSLCertificatePackValidationMethod(ctx, "4040c861546af1562fd2fb7478dc8f02", "106df4cc-8fc8-400e-b2c3-48e0d352bc10", want)
	if err != nil {
		log.Fatal(err)
	}
	fmt.Println(ver)

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation. I'm not sure how/where documentation gets updated?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

universal_ssl.go Outdated Show resolved Hide resolved
universal_ssl_test.go Outdated Show resolved Hide resolved
universal_ssl_test.go Outdated Show resolved Hide resolved
universal_ssl.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit be352ec into cloudflare:master Aug 1, 2021
@jacobbednarz
Copy link
Member

thanks for this @TheSkorm! this is great and congrats on the first contribution ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants