Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed AccessOrganizationLoginDesign type and tests #776

Conversation

trjstewart
Copy link
Contributor

Description

Resolves Issue #775. I have submitted support request #2349045 to hopefully help get the public documentation updated.

Has your change been tested?

Updated tests and they're passing locally.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@trjstewart trjstewart force-pushed the fix_access_organization_login_design_type branch from 8edf9d1 to 2a6a3be Compare March 16, 2022 10:40
@trjstewart
Copy link
Contributor Author

While the public API documentation for this isn't in line with what is correct, I have gotten confirmation from the Product Team that the correct payload for this request is as below via Support Request 2349045. I have just now sent a follow-up request (2400581) to hopefully get an update on documentation.

{
  "login_design": {
    "background_color": "redacted",
    "logo_path": "redacted",
    "text_color": "redacted",
    "header_text": "redacted",
    "footer_text": "redacted"
  }
}

@Justin-Holmes
Copy link
Contributor

Thanks @trjstewart for adding this 🙏 . The new payload should be reflected in our API docs in the next several days: https://api.cloudflare.com/.

@jacobbednarz This gets my approval on the Access side!

@jacobbednarz jacobbednarz merged commit 06fe31d into cloudflare:master Apr 20, 2022
@jacobbednarz
Copy link
Member

thanks, i saw this one come through internally. great news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants