Change ratelimit mitigation_expression to counting_expression
#808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakcutner
force-pushed
the
ratelimit-counting-expression
branch
from
a635d9b
to
80ea884
Compare
zakcutner
commented
Feb 18, 2022
| @@ -255,10 +255,7 @@ type RulesetRuleRateLimit struct { | |||
| RequestsPerPeriod int `json:"requests_per_period,omitempty"` | |||
| Period int `json:"period,omitempty"` | |||
| MitigationTimeout int `json:"mitigation_timeout,omitempty"` | |||
|
|
|||
| // Should always be sent as "" will trigger the service to use the Ruleset | |||
There was a problem hiding this comment.
This is an optional field so should not be sent unless it is used
This reflects a change in the public API, summarised in the following table: | | counting expression | mitigation expression | |--------|---------------------------------|-----------------------------------| | before | `expression` | `ratelimit.mitigation_expression` | | after | `ratelimit.counting_expression` | `expression` | In both cases, setting `ratelimit.counting_expression` or `ratelimit.mitigation_expression` to the empty string (or not setting it at all) signifies that it should take the same value as `expression`.
zakcutner
force-pushed
the
ratelimit-counting-expression
branch
from
80ea884
to
27afcca
Compare
jacobbednarz
added a commit
to cloudflare/terraform-provider-cloudflare
that referenced
this pull request
Feb 20, 2022
…ing_expression` Internally, the `mitigation_expression` field has moved to `counting_expression` to better match its use. This updates the schema to reflect those changes and migrate state files to match. Depends on cloudflare/cloudflare-go#808
jacobbednarz
added a commit
to cloudflare/terraform-provider-cloudflare
that referenced
this pull request
Feb 20, 2022
…ing_expression` Internally, the `mitigation_expression` field has moved to `counting_expression` to better match its use. This updates the schema to reflect those changes and migrate state files to match. Depends on cloudflare/cloudflare-go#808
jacobbednarz
added a commit
to cloudflare/terraform-provider-cloudflare
that referenced
this pull request
Feb 22, 2022
…ing_expression` Internally, the `mitigation_expression` field has moved to `counting_expression` to better match its use. This updates the schema to reflect those changes and migrate state files to match. Depends on cloudflare/cloudflare-go#808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reflects a change in the public API, summarised in the following
table:
expressionratelimit.mitigation_expressionratelimit.counting_expressionexpressionIn both cases, setting
ratelimit.counting_expressionorratelimit.mitigation_expressionto the empty string (or not setting itat all) signifies that it should take the same value as
expression.Types of changes
What sort of change does your code introduce/modify?
Checklist: