Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waiting Room status method #812

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

broswen
Copy link
Contributor

@broswen broswen commented Feb 21, 2022

Description

I added the method WaitingRoomStatus (maybe GetWaitingRoomStatus?) to get the current status of a Waiting Room.

I left the status property as a string in the Go struct. This could be updated to an explicit status type if necessary.

Has your change been tested?

I have added a TestWaitingRoomStatus test in waiting_room_test.go.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@jacobbednarz
Copy link
Member

nice! thank you! 👏

@jacobbednarz jacobbednarz merged commit a4ac2df into cloudflare:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants