Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Enabled within RulesetRuleActionParametersCategories optional for DDoS L7 phase #824

Merged
merged 1 commit into from
Mar 7, 2022
Merged

fix: make Enabled within RulesetRuleActionParametersCategories optional for DDoS L7 phase #824

merged 1 commit into from
Mar 7, 2022

Conversation

Quentin-M
Copy link
Contributor

Description

As per the API response while configuring ruleset category override in ddos_l7, the Enabled field cannot be used:
DDoS L7 overrides cannot use the enabled field, DDoS L7 overrides cannot use the enabled field

Therefore, this commit makes the field optional.

    "overrides": {
     "categories": [
      {
       // INVALID
       "category": "unusual-requests",
       "action": "challenge",
       "enabled": false
      },
      {
       // VALID
       "category": "botnets",
       "action": "challenge",
      }
     ],

Has your change been tested?

The change was tested within cloudflare/terraform-provider-cloudflare via a nacceptance test as well as by running the provider itself within Terraform.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • Unclear to me at this time where a documentation change might be required.
  • Have not identified any relevant test associated with this structure after doing a quick code search.

As per the API response while configuring ruleset category override in ddos_l7, the Enabled field cannot be used:
    DDoS L7 overrides cannot use the enabled field, DDoS L7 overrides cannot use the enabled field

Therefore, this commit makes the field optional.

```
    "overrides": {
     "categories": [
      {
       // INVALID
       "category": "unusual-requests",
       "action": "challenge",
       "enabled": false
      },
      {
       // VALID
       "category": "botnets",
       "action": "challenge",
      }
     ],
@jacobbednarz
Copy link
Member

appreciate this @Quentin-M!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants