This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Collapse with PostHTML and PostCSS plugins #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terinjokes
force-pushed
the
terin/post
branch
2 times, most recently
from
d540da1
to
3291441
Compare
| var tasks = []; | ||
|
|
||
| css.walkAtRules('import', function (importRule) { | ||
| var matches = /(?:url\()?['"]?([^'"\)\s]*)['"]?(?:\))?(?:\s+(.+))?/gi.exec(importRule.params); |
There was a problem hiding this comment.
Can't we use value parser here as well instead of handwritten regular expression?
There was a problem hiding this comment.
Probably, I'll give it a shot. Think I might moved this regex from the old parser to here.
terinjokes
force-pushed
the
terin/post
branch
2 times, most recently
from
e8a26e0
to
4ac7361
Compare
Check in a lockfile before beginning any updating and refactoring tasks, to have a solid base going forward.
In the CLI tool, the ndjson is formatted with `ndjson-logrus` to have nicer, human-friendly output.
|
Merging this one as-is and will issue another PR with dependency upgrades and more refactoring on top of it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large refactor of Collapsify, now with a decent amount of tests, that implements the collapsing functionality as PostHTML and PostCSS AST transforming plugins.
By implementing Collapsify as plugins we can leverage the large ecosystem's plugin, parsing and output generation. The desire is that this allows new features to be added to Collapsify with greater ease, and decrease the number of collapsing issues.