Prepare to release daphne_worker 0.1.1 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to upgrade `daphne_worker` to `worker` version 0.0.11, we need a published version of `daphne` without the `worker` dependency.
cjpatton
force-pushed
the
cjpatton/ops/15/daphne-worker-0.1.1-publish
branch
from
0fc80db
to
2b596d9
Compare
This version includes various features we need, including a bugfix for DO alarm. Accordingly, fix the computation of the duration passed to `set_alarm()` in `HelperStateStore`.
cjpatton
force-pushed
the
cjpatton/ops/15/daphne-worker-0.1.1-publish
branch
from
2b596d9
to
059469f
Compare
armfazh
approved these changes
Aug 31, 2022
|
New crate published: https://crates.io/crates/daphne_worker/0.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107.
The main change is upgrading to
workerversion 0.0.11, which is necessary in order to publish a new version of thedaphne_workercrate. The new version ofworkerincludes a bugfix for DO alarams, which allows us to also close #107.In order to get
daphne_workerto compile to WASM, we need to ensure we depend on a single version of theworkercrate. But sincedaphne_workerusesdaphneversion 0.1.0, which still has theworkerdependency, we end up building two version of theworker. To resolve this, a new version ofdaphnewas cut with theworkerdependency removed. This has already been published: https://crates.io/crates/daphne/0.1.1/dependenciesNext steps after merging this change:
daphne_workerversion 0.1.1 (trycargo publish --dry-runto make sure this will work)daphneversion 0.1.0 anddaphne_workerversion 0.1.0 from crates.io so that no one tries to use them.