Minor adjustsments #276
Merged
Minor adjustsments #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrik
reviewed
Sep 22, 2023
| @@ -3,15 +3,15 @@ | |||
| #include <bpf/bpf_tracing.h> | |||
|
|
|||
| #if defined(__TARGET_ARCH_x86) | |||
| #define FENTRY_SEC() SEC("fentry/__x64_sys_getpid") | |||
| #define FENTRY_SEC() SEC("fentry/__do_sys_getpid") | |||
There was a problem hiding this comment.
I can see both on our x86_64 running v6.1:
$ cat /proc/kallsyms | grep -E '( __x64_sys_getpid|__do_sys_getpid)$'
0000000000000000 t __do_sys_getpid
0000000000000000 T __x64_sys_getpid
On arm64 we only have one:
$ cat /proc/kallsyms | grep -E '( __arm64_sys_getpid|__do_sys_getpid)$'
0000000000000000 T __arm64_sys_getpid
Switching to __do_sys_getpid makes sense given what you say, even if it makes me sad for the lack of consistency.
Wanted to demo the shorter URL https://git.kernel.org/torvalds/c/. Plus, adding desc "subject" after commit SHA like kernel commits usually does for e.g. Fixes tags. Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>
On my kernel __x64_sys_getpid() is not available in BTF vmlinux. The function __do_sys_getpid() is to use that instead. Tested on kernels: - 6.4.10-200.fc38.x86_64 - 6.5.0-rc5-net-next Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bobrik
I made these two small adjustments while trying out the benchmarks in ebpf_exporter.