Construct metrics registry with default() when name_in_metrics is empty #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a clause to use `Registry::default()` if `name_in_metrics` is empty At the moment using the `with_prefix` method, the metrics that get rendered ends up looking like this: `_my_metric` because `prefix` is `Option` https://github.com/prometheus/client_rust/blob/master/src/registry.rs#L62 Using `Registry::default()` will set prefix to `None` so that metrics get rendered without the leading underscore.
inikulin
approved these changes
Mar 20, 2024
cbranch
approved these changes
Mar 20, 2024
nox
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a clause to use
Registry::default()ifname_in_metricsis emptyAt the moment using the
with_prefixmethod, the metrics that get rendered ends up looking like this:_my_metricbecauseprefixisOptionhttps://github.com/prometheus/client_rust/blob/master/src/registry.rs#L62
Using
Registry::default()will set prefix toNoneso that metrics get rendered without the leading underscore.