Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Windows #22

Closed
lucasepe opened this issue Mar 5, 2019 · 2 comments
Closed

Build on Windows #22

lucasepe opened this issue Mar 5, 2019 · 2 comments

Comments

@lucasepe
Copy link

lucasepe commented Mar 5, 2019

Go getting and building gokey on Windows OS

go get github.com/cloudflare/gokey/cmd/gokey

gives this errors:

# github.com/cloudflare/gokey/cmd/gokey
...\src\github.com\cloudflare\gokey\cmd\gokey\main.go:121:43: cannot use syscall.Stdin (type syscall.Handle) as type int in argument to terminal.ReadPassword
...\src\github.com\cloudflare\gokey\cmd\gokey\main.go:133:47: cannot use syscall.Stdin (type syscall.Handle) as type int in argument to terminal.ReadPassword

The build is successful after replacing in main.go:

terminal.ReadPassword(syscall.Stdin)

with:

terminal.ReadPassword(int(syscall.Stdin))
@ignatk
Copy link
Contributor

ignatk commented Mar 5, 2019

Thanks for the report. Does #23 look OK to you?

@lucasepe
Copy link
Author

lucasepe commented Mar 6, 2019

Perfect! Build OK & running. Thank you very much.

@ignatk ignatk closed this as completed in #23 Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants