Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for P-384, also known as secp384r1 #35

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Add support for P-384, also known as secp384r1 #35

merged 1 commit into from
Aug 9, 2021

Conversation

awnumar
Copy link
Contributor

@awnumar awnumar commented Aug 9, 2021 •
edited
Loading

This PR adds support for the NIST P-384 curve to gokey.

@awnumar
Copy link
Contributor Author

awnumar commented Aug 9, 2021

Fixed the failing test 👍🏽 I forgot to run go generate

ignatk
ignatk reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@ignatk ignatk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for the contribution. Could you, please, add EC384 to test files as well where we testEC256 and EC521?

And the docs in the README?

@awnumar
Copy link
Contributor Author

awnumar commented Aug 9, 2021

Thanks for the contribution. Could you, please, add EC384 to test files as well where we testEC256 and EC521?

Hi, thanks for the comment. I've updated the documentation. In terms of the tests, do you mean here?

@ignatk
Copy link
Contributor

ignatk commented Aug 9, 2021

Yes. Looks good. Can you squash the commits now?

@awnumar
Copy link
Contributor Author

awnumar commented Aug 9, 2021

Yes. Looks good. Can you squash the commits now?

All done

@ignatk ignatk merged commit 2d48d3b into cloudflare:master Aug 9, 2021
@awnumar awnumar deleted the ec384 branch August 9, 2021 11:27
@awnumar awnumar restored the ec384 branch August 9, 2021 11:33
@intUnderflow intUnderflow deleted the ec384 branch October 24, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignatk ignatk ignatk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@awnumar @ignatk